Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW 882: Integrate Seed Verification Flow To Integration Tests #1966

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Blazebrain
Copy link
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

static const int verificationWordsCount = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? we want this to skip verification in debug
let's find a way to make the tests run in release mode, if not, then we can find a different approach, maybe set it in an environment variable and use that or if you have something else in mind

or use the TestAssetBundle that you made

Comment on lines -171 to -179
//* ======Confirm it displays the properly formatted title===========
final transactionType = dashboardViewModel.getTransactionType(item.transaction);

final title = item.formattedTitle + item.formattedStatus + transactionType;

commonTestCases.findWidgetViaDescendant(
of: find.byKey(ValueKey(keyId)),
matching: find.text(title),
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add a TODO there, there's been some inconsistencies with the wordings for the title, something from the flutter end as it doesn't constantly happen. Happens once, and when you rerun, it doesn't happen again. I think I mentioned earlier on one of the calls.

Comment on lines -54 to -62
final onAuthPage = authPageRobot.onAuthPage();
if (onAuthPage) {
await authPageRobot.enterPinCode(CommonTestConstants.pin);
}

final onAuthPageDesktop = authPageRobot.onAuthPageDesktop();
if (onAuthPageDesktop) {
await authPageRobot.enterPassword(CommonTestConstants.pin.join(""));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the exchange flow have the potential to show the auth page? why remove it then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the exchange flow have the potential to show the auth page? why remove it then?

It has already been handled in the Exchange flow robot, in the flow that handles all events post exchange.

I didn't add it in earlier, I think it was added with the desktop flow setup done earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants